[ https://issues.apache.org/jira/browse/CLOUDSTACK-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074822#comment-15074822 ]
ASF GitHub Bot commented on CLOUDSTACK-9203: -------------------------------------------- GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java server/src/com/cloud/vm/UserVmManager.java server/src/com/cloud/vm/UserVmManagerImpl.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9203 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1297 ---- commit c1040f0fb004c2aa4f39d8d8c195f9334a7b6014 Author: Loic Lambiel <l...@exoscale.ch> Date: 2015-05-13T14:43:09Z CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java server/src/com/cloud/vm/UserVmManager.java server/src/com/cloud/vm/UserVmManagerImpl.java ---- > [API] extend updateVirtualMachine to support updating security groups > --------------------------------------------------------------------- > > Key: CLOUDSTACK-9203 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9203 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API > Reporter: René Moser > Assignee: Daan Hoogland > Priority: Minor > Fix For: Future > > > There is currently no way to change security groups on exisitng VMs. > {{updateVirtualMachine}} should be extended in a similar way as > {{deployVirtualMachine}} which should allow passing a list of IDs or names to > update the security groups as passed: > {{securitygroupids}} parameter > comma separated list of security groups id that going to be applied to the > virtual machine. Should be passed only when vm is created from a zone with > Basic Network support. Mutually exclusive with securitygroupnames parameter, > default: false > {{securitygroupnames}} parameter > comma separated list of security groups names that going to be applied to the > virtual machine. Should be passed only when vm is created from a zone with > Basic Network support. Mutually exclusive with securitygroupids parameter. > default: false > Exoscale did already some work in their branch which we are > [allowed|https://twitter.com/resmo79/status/681428989018267648] to use, see > [https://github.com/exoscale/cloudstack/pull/6/] -- This message was sent by Atlassian JIRA (v6.3.4#6332)