[ https://issues.apache.org/jira/browse/CLOUDSTACK-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082989#comment-15082989 ]
ASF GitHub Bot commented on CLOUDSTACK-9203: -------------------------------------------- Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1297#discussion_r48840815 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2288,6 +2290,7 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx String hostName = cmd.getHostName(); Map<String,String> details = cmd.getDetails(); Account caller = CallContext.current().getCallingAccount(); + List<Long> securityGroupIdList = getSecurityGroupIdList(cmd); --- End diff -- The updateVirtualMachine below can handle the null value (see line 2463) > [API] extend updateVirtualMachine to support updating security groups > --------------------------------------------------------------------- > > Key: CLOUDSTACK-9203 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9203 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API > Reporter: René Moser > Assignee: Daan Hoogland > Priority: Minor > Fix For: Future > > > There is currently no way to change security groups on exisitng VMs. > {{updateVirtualMachine}} should be extended in a similar way as > {{deployVirtualMachine}} which should allow passing a list of IDs or names to > update the security groups as passed: > {{securitygroupids}} parameter > comma separated list of security groups id that going to be applied to the > virtual machine. Should be passed only when vm is created from a zone with > Basic Network support. Mutually exclusive with securitygroupnames parameter, > default: false > {{securitygroupnames}} parameter > comma separated list of security groups names that going to be applied to the > virtual machine. Should be passed only when vm is created from a zone with > Basic Network support. Mutually exclusive with securitygroupids parameter. > default: false > Exoscale did already some work in their branch which we are > [allowed|https://twitter.com/resmo79/status/681428989018267648] to use, see > [https://github.com/exoscale/cloudstack/pull/6/] -- This message was sent by Atlassian JIRA (v6.3.4#6332)