[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174614#comment-15174614
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9298:
--------------------------------------------

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1425#issuecomment-190961759
  
    @nvazquez and @pedro-martins, 
    I am ok with the code now, expect the constructor bit.
    The question you should ask about the constructor is, is it used NOW? If 
not, why create it. In the future when the need appear, we can create it; this 
way we can avoid unused code that may be left aside and never used.
    
    Additionally, I am with @pedro-martins, if you like, tests cases would be 
pretty welcome here.



> Improve performance of resource retrieval that have tags associated and 
> target volumes, VMs and templates
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9298
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9298
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.9.0
>            Reporter: Nicolas Vazquez
>             Fix For: 4.9.0
>
>
> h2. Description of the problem
> When retrieving a large number of resources which have tags associated with, 
> retrieval methods took too long. Our goal is to improve performance of this 
> methods
> h3. ListTemplatesCmd API method
> It is proposed to include tags information into template_view to avoid 
> querying the database for each tag, managing that information in memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to