[
https://issues.apache.org/jira/browse/CLOUDSTACK-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178787#comment-15178787
]
ASF GitHub Bot commented on CLOUDSTACK-9298:
--------------------------------------------
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1425#discussion_r54964238
--- Diff:
server/src/com/cloud/api/query/dao/GenericDaoBaseWithTagInformation.java ---
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.api.query.dao;
+
+import java.io.Serializable;
+
+import org.apache.cloudstack.api.BaseResponseWithTagInformation;
+
+import com.cloud.api.ApiDBUtils;
+import com.cloud.api.query.vo.BaseViewWithTagInformationVO;
+import com.cloud.api.query.vo.ResourceTagJoinVO;
+import com.cloud.utils.db.GenericDaoBase;
+
+public abstract class GenericDaoBaseWithTagInformation<T extends
BaseViewWithTagInformationVO,
--- End diff --
Why create a type ID that extends Serializable, if this type definition is
always Long?
I think it is better to use "public abstract class
GenericDaoBaseWithTagInformation<T extends BaseViewWithTagInformationVO, Z
extends BaseResponseWithTagInformation> extends GenericDaoBase<T, Long> {..}"
> Improve performance of resource retrieval that have tags associated and
> target volumes, VMs and templates
> ---------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9298
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9298
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.9.0
> Reporter: Nicolas Vazquez
> Fix For: 4.9.0
>
>
> h2. Description of the problem
> When retrieving a large number of resources which have tags associated with,
> retrieval methods took too long. Our goal is to improve performance of this
> methods
> h3. ListTemplatesCmd API method
> It is proposed to include tags information into template_view to avoid
> querying the database for each tag, managing that information in memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
