[
https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303582#comment-15303582
]
ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-222067277
Hi! Talking with @footplus on the mailing list, I realized that this patch
is not correct. It's missing modifications on the VO objects to let the String
holds more than 255 characters because in the `GenericDaoBase`, `String` fields
are by default of 255 chars, see:
https://github.com/apache/cloudstack/blob/master/framework/db/src/com/cloud/utils/db/GenericDaoBase.java#L1510
This PR should be updated, or should there be a new one to add those
changes?
> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
> Key: CLOUDSTACK-9238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0, 4.7.0, 4.8.0
> Reporter: Wido den Hollander
> Assignee: Wido den Hollander
> Labels: s3, template, templates, url, urls
> Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a
> VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and
> the 'url' field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No
> code-change is required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
