[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303609#comment-15303609
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9238:
--------------------------------------------

GitHub user marcaurele opened a pull request:

    https://github.com/apache/cloudstack/pull/1567

    CLOUDSTACK-9238: Fix URL length to 2048 for all url fields in VO

    I will update the PR to add max field length in the API commands too

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/exoscale/cloudstack CLOUDSTACK-9238

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1567
    
----
commit a59ee03fd79806dcb3a8842c318e2cd06895183f
Author: Marc-Aurèle Brothier <m...@brothier.org>
Date:   2016-05-27T06:16:05Z

    Fix URL length to 2048 for all url fields in VO

----


> URL fields in database are to small. Cause malformed URLs
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-9238
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9238
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.6.0, 4.7.0, 4.8.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>              Labels: s3, template, templates, url, urls
>             Fix For: 4.8.0
>
>
> In for example the 'volume_store_ref' table the 'download_url' field is a 
> VARCHAR(255).
> This is to short for URLs. Same goes for the 'object_datastore_ref' table and 
> the 'url' field.
> With pre-signed S3 URLs this will cause issues.
> The fix would be to change the database fields to a VARCHAR(2048). No 
> code-change is required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to