[ https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710059#comment-15710059 ]
ASF GitHub Bot commented on CLOUDSTACK-9632: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90339460 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO cert, List<LoadBalancerCertM return response; } - private void validateCert(Certificate cert, boolean chainPresent) { + private void validateCert(final Certificate cert, final boolean chainPresent) { - if (!(cert instanceof X509Certificate)) + if (!(cert instanceof X509Certificate)) { throw new IllegalArgumentException("Invalid certificate format. Expected X509 certificate"); + } try { ((X509Certificate)cert).checkValidity(); - } catch (Exception e) { + } catch (final Exception e) { throw new IllegalArgumentException("Certificate expired or not valid", e); } } - private void validateKeys(PublicKey pubKey, PrivateKey privKey) { + private void validateKeys(final PublicKey pubKey, final PrivateKey privKey) { - if (pubKey.getAlgorithm() != privKey.getAlgorithm()) + if (pubKey.getAlgorithm() != privKey.getAlgorithm()) { throw new IllegalArgumentException("Public and private key have different algorithms"); + } --- End diff -- Please consider refactoring to `Preconditions.checkArgument` to DRY the code. Also, please add a check that `pubKey` is not `null`. > Upgrade bountycastle to 1.55+ > ----------------------------- > > Key: CLOUDSTACK-9632 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0 > > > Upgrade bountycastle library to latest versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)