[ https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710045#comment-15710045 ]
ASF GitHub Bot commented on CLOUDSTACK-9632: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90314765 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -176,18 +176,18 @@ public void runUploadSslCertSelfSignedWithPassword() throws Exception { when(certService._accountDao.findByIdIncludingRemoved(anyLong())).thenReturn((AccountVO)account); //creating the command - UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn(); - Class<?> _class = uploadCmd.getClass().getSuperclass(); + final UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn(); + final Class<?> klazz = uploadCmd.getClass().getSuperclass(); - Field certField = _class.getDeclaredField("cert"); + final Field certField = klazz.getDeclaredField("cert"); certField.setAccessible(true); certField.set(uploadCmd, cert); - Field keyField = _class.getDeclaredField("key"); + final Field keyField = klazz.getDeclaredField("key"); keyField.setAccessible(true); keyField.set(uploadCmd, key); - Field passField = _class.getDeclaredField("password"); + final Field passField = klazz.getDeclaredField("password"); passField.setAccessible(true); passField.set(uploadCmd, password); --- End diff -- This method has not assertions to verify the correctness of `certService.uploadSslCert`. Please consider adding such assertions. > Upgrade bountycastle to 1.55+ > ----------------------------- > > Key: CLOUDSTACK-9632 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0 > > > Upgrade bountycastle library to latest versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)