[ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15910236#comment-15910236 ]
ASF GitHub Bot commented on CLOUDSTACK-8855: -------------------------------------------- Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r105723444 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java --- @@ -100,17 +103,18 @@ public Long getInstanceId() { @Override public void execute() { try { - Host result = _resourceService.reconnectHost(this); - if (result != null) { - HostResponse response = _responseGenerator.createHostResponse(result); - response.setResponseName(getCommandName()); - this.setResponseObject(response); - } else { - throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to reconnect host"); - } - } catch (Exception ex) { - s_logger.warn("Exception: ", ex); - throw new ServerApiException(ApiErrorCode.RESOURCE_UNAVAILABLE_ERROR, ex.getMessage()); + Host result =_resourceService.reconnectHost(this); --- End diff -- Before the `result` was checked for `null`; can the method `_resourceService.reconnectHost(this)` return null? > Improve Error Message for Host Alert State > ------------------------------------------ > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Affects Versions: 4.6.0 > Reporter: Bharat Kumar > Assignee: Bharat Kumar > -- This message was sent by Atlassian JIRA (v6.3.15#6346)