[
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924425#comment-15924425
]
ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105942978
--- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
@@ -141,7 +142,7 @@
public void pullAgentOutMaintenance(long hostId);
- boolean reconnect(long hostId);
+ void reconnect(long hostId) throws CloudRuntimeException,
AgentUnavailableException;
--- End diff --
@bvbharatk I got your intentions here. However, don’t you think we can work
out the places where people are login runtime exceptions, instead of bubbling
them up? I believe that instead of creating constraints in the code, we should
spot when people are introducing these things, and educate them. For the code
that is already doing the things you mentioned, well, we can work to fix them
bit by bit.
It feels a little unusual (at least for me) to declare runtime exceptions.
At the end of the day, you may make it more visible, but just because you
declare a runtime exception, it does not mean people will be forced to catch it
(they will not be forced to catch it).
BTW: I never had a good expression to talk about the re-throw of
exceptions. Thanks for the “bubble exception up”.
> Improve Error Message for Host Alert State
> ------------------------------------------
>
> Key: CLOUDSTACK-8855
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.6.0
> Reporter: Bharat Kumar
> Assignee: Bharat Kumar
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
