[
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216066#comment-16216066
]
ASF GitHub Bot commented on CLOUDSTACK-10024:
---------------------------------------------
GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024:
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r146418796
##########
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1196,6 +1222,10 @@ private void getPifs() {
s_logger.debug("done looking for pifs, no more bridges");
}
+ boolean isGuestBridge(String bridge) {
Review comment:
Thanks! Removing the duplicate code is great 👍
If you want, you can go a step further creating a test case for
`isGuestBridge(String bridge)` and `isPublicBridge(String bridge)` ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Physical Networking Migration
> -----------------------------
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API, KVM, Management Server, VMware
> Reporter: Frank Maximus
> Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network
> infrastructure
> *In order to* make use of the extra features SDN provides.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
