[
https://issues.apache.org/jira/browse/CLOUDSTACK-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216057#comment-16216057
]
ASF GitHub Bot commented on CLOUDSTACK-10024:
---------------------------------------------
GabrielBrascher commented on a change in pull request #2259: CLOUDSTACK-10024:
Network migration support
URL: https://github.com/apache/cloudstack/pull/2259#discussion_r141427671
##########
File path: api/src/com/cloud/network/NetworkService.java
##########
@@ -82,6 +83,26 @@ IpAddress allocatePortableIP(Account ipOwner, int regionId,
Long zoneId, Long ne
Network updateGuestNetwork(long networkId, String name, String
displayText, Account callerAccount, User callerUser, String domainSuffix, Long
networkOfferingId,
Boolean changeCidr, String guestVmCidr, Boolean displayNetwork, String
newUUID, boolean updateInSequence, boolean forced);
+ /**
+ * Migrate a network from one physical network to another physical network
+ * @param networkId
+ * @param networkOfferingId
+ * @param callerAccount
+ * @param callerUser
+ * @return
Review comment:
Thanks for documenting the code @sgoeminn.
Please, remove the `@param` and `@return`. I don't see much use of them
(unless they are detailed). The same goes for method 'migrateVpcNetwork'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Physical Networking Migration
> -----------------------------
>
> Key: CLOUDSTACK-10024
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10024
> Project: CloudStack
> Issue Type: New Feature
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API, KVM, Management Server, VMware
> Reporter: Frank Maximus
> Assignee: Frank Maximus
> Fix For: 4.11.0.0
>
>
> *As a* Cloud Owner
> *I want to* migrate my existing guest networks to another physical network
> infrastructure
> *In order to* make use of the extra features SDN provides.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
