[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449371#comment-16449371
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
---------------------------------------------
marcaurele commented on a change in pull request #2595: CLOUDSTACK-10199:
Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r183616840
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -883,6 +885,73 @@ public void saveExtraDhcpOptions(final String
networkUuid, final Long nicId, fin
return new Pair<NicProfile, Integer>(vmNic, Integer.valueOf(deviceId));
}
+ /**
+ * If the requested IPv4 address from the NicProfile was configured then
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the
requested IP.
+ */
+ protected void configureNicProfileBasedOnRequestedIp(NicProfile
requestedNicProfile, NicProfile nicProfile, Network network) {
+ String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+ if (requestedIpv4Address == null) {
+ s_logger.debug(String.format("The requested [IPv4 address=%s] is
null", requestedIpv4Address));
+ return;
+ }
+ if
(org.apache.commons.lang3.StringUtils.isBlank(requestedIpv4Address)) {
+ throw new InvalidParameterValueException(String.format("The
requested [IPv4 address='%s'] is empty or blank", requestedIpv4Address));
+ }
+ if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+ throw new InvalidParameterValueException(String.format("The
requested [IPv4 address='%s'] is not a valid IP address",
requestedIpv4Address));
+ }
+
+ VlanVO vlanVo = _vlanDao.findByNetworkId(network.getId());
+ if (vlanVo == null) {
+ throw new CloudRuntimeException(String.format("Trying to configure
a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the [network
id='%s']",
+ requestedIpv4Address, network.getId()));
+ }
+
+ acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+ String ipv4Gateway = vlanVo.getVlanGateway();
+ String ipv4Netmask = vlanVo.getVlanNetmask();
+
+ if (org.apache.commons.lang3.StringUtils.isBlank(ipv4Gateway) ||
!NetUtils.isValidIp4(ipv4Gateway)) {
+ throw new CloudRuntimeException(String.format("The
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway,
vlanVo.getId()));
+ }
+ if (org.apache.commons.lang3.StringUtils.isBlank(ipv4Netmask) ||
!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+ throw new CloudRuntimeException(String.format("The
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask,
vlanVo.getId()));
+ }
+
+ nicProfile.setIPv4Address(requestedIpv4Address);
+ nicProfile.setIPv4Gateway(ipv4Gateway);
+ nicProfile.setIPv4Netmask(ipv4Netmask);
+
+ if (nicProfile.getMacAddress() == null) {
+ try {
+ String macAddress =
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+ nicProfile.setMacAddress(macAddress);
+ } catch (InsufficientAddressCapacityException e) {
+ e.printStackTrace();
+ }
+ }
+ }
+
+ /**
+ * Acquires lock of in table "user_ip_address" and checks if the
requested IPv4 address is Free.
+ */
+ protected void acquireLockAndCheckIfIpv4IsFree(Network network, String
requestedIpv4Address) {
+ IPAddressVO ipVO =
_ipAddressDao.findByIpAndSourceNetworkId(network.getId(), requestedIpv4Address);
+ if (ipVO == null) {
+ throw new CloudRuntimeException(String.format("Cannot find
IPAddressVO for guest [IPv4 address='%s'] and [network id=%s]",
requestedIpv4Address, network.getId()));
+ }
+ IPAddressVO lockedIpVO =
_ipAddressDao.acquireInLockTable(ipVO.getId());
Review comment:
`lockedIpVO` can be `null`
(https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java#L1049).
Moreover, it would be better IMO to put the lock/release operation with a
`try/finally` block to ensure to release the lock all the time (when it could
get it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
> Reporter: Wido den Hollander
> Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
