[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449598#comment-16449598
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
---------------------------------------------
rafaelweingartner commented on a change in pull request #2595:
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r183680786
##########
File path: engine/schema/src/main/java/com/cloud/dc/dao/VlanDaoImpl.java
##########
@@ -81,6 +81,22 @@ public VlanVO findByZoneAndVlanId(long zoneId, String
vlanId) {
sc.setParameters("vlanId", vlanId);
return findOneBy(sc);
}
+
+ /**
+ * Returns a vlan by the network id.
+ */
+ @Override
+ public VlanVO findByNetworkId(long networkId) {
+ List<VlanVO> vlanVoList = listVlansByNetworkId(networkId);
+ VlanVO vlanVo = null;
+ for (VlanVO vlan : vlanVoList) {
+ if (vlan.getRemoved() == null) {
Review comment:
I have the same doubt. It looks like a logic that should be somewhere else.
If the network can use multiple `Vlan`, then should not you look for the
correct one (the one that is in the same CIDR) as the requested IPv4?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
> Reporter: Wido den Hollander
> Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
