[
https://issues.apache.org/jira/browse/CLOUDSTACK-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449540#comment-16449540
]
ASF GitHub Bot commented on CLOUDSTACK-10364:
---------------------------------------------
BruceKuiLiu opened a new pull request #2601: CLOUDSTACK-10364: Change the
"setXXX" method names to "getXXX".
URL: https://github.com/apache/cloudstack/pull/2601
The two methods are named as "setXXX",
actually, they are not setter but getter.
Thus, they should be renamed as "getXXX".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsiste "setXXX" method names.
> ---------------------------------
>
> Key: CLOUDSTACK-10364
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10364
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: KuiLIU
> Priority: Major
>
> The following two methods are named as "setXXX",
> actually, they are not setter but getter.
> Thus, they should be renamed as "getXXX".
> {code:java}
> private String setVnetBrName(String pifName, String vnetId) {
> return "br" + pifName + "-" + vnetId;
> }
> private String setVxnetBrName(String pifName, String vnetId) {
> return "brvx-" + vnetId;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
