[ https://issues.apache.org/jira/browse/NET-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708647#action_12708647 ]
Sebb commented on NET-278: -------------------------- It may be important to know that the disconnect() failed, as that usually indicates some kind of problem with the session. This is similar to calling close() on a file, which may also throw an IOException. In both cases, the correct action may be to log an error, which you can't do if no Exception is thrown. > FTPClient.disconnect() shouldn't throw IOException > -------------------------------------------------- > > Key: NET-278 > URL: https://issues.apache.org/jira/browse/NET-278 > Project: Commons Net > Issue Type: Improvement > Affects Versions: 2.0 > Environment: All > Reporter: Raffaele Sgarro > Priority: Minor > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > FTPClient.disconnect() shouldn't throw IOExceptions because it is typically > placed in a finally block and it doesn't make much sense to > try { > client.disconnect() > } catch (IOException e) { > // You can't actually do anything > } > What is the purpose of such an exception if nobody can use it? There's > nothing we can do if the client couldn't disconnect... You always usa a catch > block with a /*do nothing*/ in your samples, so I think it's only an elegant > thing to have a try block in a finally block... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.