[
https://issues.apache.org/jira/browse/NET-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733404#action_12733404
]
Raffaele Sgarro commented on NET-278:
-------------------------------------
So think I :-D
Maybe, since standard Java I/O close() can throw Exceptions, you'd better
stay this way
The matter is, there is always a place where you must swallow the Exception.
Either you (library programmer) or I (client one) have to
try {
...
} catch() {
...
} finally {
try {
...
} catch() {
*// Swallowing empty block here*
}
}
I may log this error... Do you think this would be useful? Now I'm looking
at JDK source to see why close() can throw Exception... Bah
Anyway, thanks for your time
Raffaele
> FTPClient.disconnect() shouldn't throw IOException
> --------------------------------------------------
>
> Key: NET-278
> URL: https://issues.apache.org/jira/browse/NET-278
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 2.0
> Environment: All
> Reporter: Raffaele Sgarro
> Priority: Minor
> Fix For: 3.0
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> FTPClient.disconnect() shouldn't throw IOExceptions because it is typically
> placed in a finally block and it doesn't make much sense to
> try {
> client.disconnect()
> } catch (IOException e) {
> // You can't actually do anything
> }
> What is the purpose of such an exception if nobody can use it? There's
> nothing we can do if the client couldn't disconnect... You always usa a catch
> block with a /*do nothing*/ in your samples, so I think it's only an elegant
> thing to have a try block in a finally block...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
