[
https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=646268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646268
]
ASF GitHub Bot logged work on IO-747:
-------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 11:57
Start Date: 03/Sep/21 11:57
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #268:
URL: https://github.com/apache/commons-io/pull/268#discussion_r701832678
##########
File path: pom.xml
##########
@@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much
more.
</plugins>
</build>
</profile>
+ <profile>
+ <id>release</id>
+ <properties>
+ <!-- Enable Moditect for releases. This requires JDK 9+ for the build
-->
Review comment:
That's not good. I build releases with Java 8 since we want to bind to
the JRE 8 APIs and not 9 especially with problems due to the NIO Buffer class
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646268)
Time Spent: 0.5h (was: 20m)
> Make commons-io a proper JPMS module
> ------------------------------------
>
> Key: IO-747
> URL: https://issues.apache.org/jira/browse/IO-747
> Project: Commons IO
> Issue Type: Task
> Affects Versions: 2.12.0
> Reporter: Martin Tzvetanov Grigorov
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It would be nice if commons-io provides module-info.class for Java 9+ JPMS.
>
> At the moment the project uses JDK 1.8 for the builds.
> To add module-info.java it would have to use JDK 9+ (probably 11) with
> -release=8.
> An easy way to introduce module-info.java is by using
> [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
