[
https://issues.apache.org/jira/browse/IO-747?focusedWorklogId=649888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649888
]
ASF GitHub Bot logged work on IO-747:
-------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 09:28
Start Date: 13/Sep/21 09:28
Worklog Time Spent: 10m
Work Description: jochenw commented on a change in pull request #268:
URL: https://github.com/apache/commons-io/pull/268#discussion_r707160987
##########
File path: pom.xml
##########
@@ -600,5 +630,13 @@ file comparators, endian transformation classes, and much
more.
</plugins>
</build>
</profile>
+ <profile>
+ <id>release</id>
+ <properties>
+ <!-- Enable Moditect for releases. This requires JDK 9+ for the build
-->
Review comment:
@garydgregory I think, that **release building** with Java 9+ is a more
than reasonable requirement, if we want to fit into the Java 9 ecosphere.
(There is no question, that we want that, isn't there?)
@martin-g I'd like to see two improvements:
1. Move the plugin definition into a profile, that enables the
moditect-maven-plugin only when building with Java 9+. Alternatively, set the
property moditect.skip for building with Java 8.
2. Make sure, that the apache-release profile enforces building with Java 9+.
Regarding commons-parent: My personal stance is, that we have covered
commons-io, and commons-fileupload now (Perhaps, cover a few others, in case of
demand.) Let's wait, and see, until we did a release with that, then approach
parent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 649888)
Time Spent: 1.5h (was: 1h 20m)
> Make commons-io a proper JPMS module
> ------------------------------------
>
> Key: IO-747
> URL: https://issues.apache.org/jira/browse/IO-747
> Project: Commons IO
> Issue Type: Task
> Affects Versions: 2.12.0
> Reporter: Martin Tzvetanov Grigorov
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> It would be nice if commons-io provides module-info.class for Java 9+ JPMS.
>
> At the moment the project uses JDK 1.8 for the builds.
> To add module-info.java it would have to use JDK 9+ (probably 11) with
> -release=8.
> An easy way to introduce module-info.java is by using
> [Moditect|https://github.com/moditect/moditect#adding-a-module-descriptor-to-the-project-jar]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
