wodencafe commented on pull request #296: URL: https://github.com/apache/commons-io/pull/296#issuecomment-957649989
@garydgregory Now the FileWriterWithEncoding extends ProxyWriter, and the actual Proxy class for writing is stored in ProxyWriter rather than inside FileWriterWithEncoding itself. We can probably also get rid of the write methods in FileWriterWithEncoding, and just let them delegate to the superclass ProxyWriter. This will reduce the amount of code significantly, but also the JavaDoc for those methods will be inherited from ProxyWriter. Also starting with Java 11, there is the static Writer.nullWriter(), which can be used instead of the anonymous class instance NULL_WRITER (whenever Apache Commons IO upgrades minimum version to Java 11). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
