kinow commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r741530222



##########
File path: 
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -46,9 +46,53 @@
  *
  * @since 1.4
  */
-public class FileWriterWithEncoding extends Writer {
-    // Cannot extend ProxyWriter, as requires writer to be
-    // known when super() is called
+public class FileWriterWithEncoding extends ProxyWriter {
+
+    private static final Writer NULL_WRITER = new Writer() {

Review comment:
       Just saw your comment about the `Writer.nullWriter()`, I guess that's 
where you got the name from :+1: no need to change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to