kinow commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r741586353



##########
File path: 
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final 
String charsetName, f
      */

Review comment:
       @wodencafe do we need to override the methods below? Could we just use 
the parent methods directly?

##########
File path: 
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -245,7 +240,7 @@ public FileWriterWithEncoding(final String fileName, final 
String charsetName, f
      */

Review comment:
       @wodencafe do we need to override the methods below? Could we just use 
the parent methods directly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to