wodencafe commented on a change in pull request #296:
URL: https://github.com/apache/commons-io/pull/296#discussion_r743379795
##########
File path:
src/main/java/org/apache/commons/io/output/FileWriterWithEncoding.java
##########
@@ -59,7 +57,7 @@
* @return the initialized writer
* @throws IOException if an error occurs
*/
- private static Writer initWriter(final File file, final Object encoding,
final boolean append) throws IOException {
+ private static final Writer initWriter(final File file, final Object
encoding, final boolean append) throws IOException {
Review comment:
I usually do this out of habit, but after doing some research it seems
that there is no functional difference for adding the `final` modifier to a
private static nested class. It has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
