[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761530
]
ASF GitHub Bot logged work on COLLECTIONS-802:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/22 22:45
Start Date: 24/Apr/22 22:45
Worklog Time Spent: 10m
Work Description: kinow commented on PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#issuecomment-1107932772
> oops. I must have forgotten, not realized, or master has new failures. I
very much like Guava’s collection tests as reusable and catch these minor
mistakes. I’d recommend using it elsewhere as another sanity check over your
own great testing.
I hadn't heard about that before, but looks super useful. But from the
amount of errors, that would probably be an epic task, maybe even worth of
GSoC, I think.
Thanks @ben-manes !
Issue Time Tracking
-------------------
Worklog Id: (was: 761530)
Time Spent: 1h (was: 50m)
> ReferenceMap iterator remove violates contract
> ----------------------------------------------
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
> Affects Versions: 4.4
> Reporter: Ben Manes
> Priority: Minor
> Attachments: ApacheMapTest.java
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
