[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=763415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763415
]
ASF GitHub Bot logged work on COLLECTIONS-802:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 10:34
Start Date: 28/Apr/22 10:34
Worklog Time Spent: 10m
Work Description: kinow commented on code in PR #300:
URL:
https://github.com/apache/commons-collections/pull/300#discussion_r860735919
##########
src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java:
##########
@@ -794,23 +794,21 @@ protected void nullValue() {
public boolean hasNext() {
checkMod();
while (nextNull()) {
- ReferenceEntry<K, V> e = entry;
+ ReferenceEntry<K, V> e = next;
int i = index;
while (e == null && i > 0) {
i--;
e = (ReferenceEntry<K, V>) parent.data[i];
}
- entry = e;
+ next = e;
index = i;
if (e == null) {
- currentKey = null;
- currentValue = null;
Review Comment:
Fix is here :point_up: , the rest is renaming variables.
Issue Time Tracking
-------------------
Worklog Id: (was: 763415)
Time Spent: 1h 40m (was: 1.5h)
> ReferenceMap iterator remove violates contract
> ----------------------------------------------
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
> Affects Versions: 4.4
> Reporter: Ben Manes
> Priority: Minor
> Attachments: ApacheMapTest-1.java, ApacheMapTest.java
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
