kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399251826
Hey, I was able to do the same test without changing public api so I reverted the change (even if I think those functions might be useful, it could be done in another PR if necessary. I added code to save tmp file in case of error during test (catched throwable, I don't like it but had no idea how to do it in another way). For memory I tried to isolate ByteArrayOutputStream in blocks to allow GC to collect them as soon as possible, I hope it helps. when you think it is ok I can resubmit the same patch in only one commit (or update it if you think there are more changes to do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
