nbauma109 commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1441409944
##########
src/main/java/org/apache/bcel/generic/LDC.java:
##########
@@ -109,6 +111,9 @@ public Object getValue(final ConstantPoolGen cpg) {
final int nameIndex = ((org.apache.bcel.classfile.ConstantClass)
c).getNameIndex();
c = cpg.getConstantPool().getConstant(nameIndex);
return
Type.getType(Type.internalTypeNameToSignature(((org.apache.bcel.classfile.ConstantUtf8)
c).getBytes()));
+ case org.apache.bcel.Const.CONSTANT_Dynamic:
+ // Really not sure what to return here, maybe a BootstrapMethod
instance but how do we get it?
+ return c;
Review Comment:
The value of a constant dynamic is only known at runtime, so I guess it can
only return an arbitrary value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
