gtoison commented on PR #254: URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877205250
Hum, you're right: I misread and thought it was only for long and double constants but it was also modified for dynamic constants. Currently `LDC2_W.getValue()` returns a `Number` (while `LDC.getValue()` returns an `Object`. Updating it would require modifying the return type of the method, so it could be a breaking change for client code using BCEL. It also remains an open question as to _what_ should be returned by `getValue()` since the value is computed at runtime. I'll look into modifying LDC2_W as well, thanks for pointing this out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
