gtoison commented on PR #254: URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877760451
Thanks for checking @JuditKnoll I think I could come up with something sensible for [ConstantPoolX.constantToString()](https://github.com/apache/commons-bcel/blob/master/src/test/java/org/apache/bcel/data/ConstantPoolX.java#L96) but [ConstantPoolGen.addConstant()](https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java#L275) seems outside of the scope of this PR @garydgregory, shall I add a new line to [src/changes/changes.xml](https://github.com/apache/commons-bcel/blob/fbc58b1d4693048c50849be2027a9b526ab4c462/src/changes/changes.xml)? Regarding the coverage: the updated/uncovered lines are in the logic for rejecting invalid classes, so the case of a valid class is covered, but an invalid case isn't (e.g `LDC CONSTANT_Module`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
