struberg commented on code in PR #1328:
URL: https://github.com/apache/commons-lang/pull/1328#discussion_r1869773297
##########
src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java:
##########
@@ -115,6 +116,11 @@ private static void reflectionAppend(
final boolean useTransients,
final String[] excludeFields) {
+ if ((lhs instanceof CharSequence || lhs instanceof Number || lhs
instanceof Temporal) && lhs instanceof Comparable) {
+ builder.append(lhs, rhs);
+ return;
+ }
+
Review Comment:
made the blank line because it's really a totally separate block which
handles 'primitives&friends'
Note that there is likely a bunch more we need to handle, and we still don't
handle the illegal access in a general sense, e.g. when you have closed modules
in custom packages, etc. But at least the build works again now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
