garydgregory commented on code in PR #1328:
URL: https://github.com/apache/commons-lang/pull/1328#discussion_r1870260526
##########
src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java:
##########
@@ -867,4 +874,21 @@ private void validate() {
}
}
+ private boolean handleNativeClasses() {
+ Object value = getObject();
+ if (value instanceof Number || value instanceof Boolean || value
instanceof Character
+ || value instanceof TemporalAccessor) {
Review Comment:
This expression uses `TemporalAccessor` here but the new
`isJavaInternalClass()` uses `Temporal`. `Temporal` extends `TemporalAccessor`,
why is there a difference? It seems this expression could be rewritten to call
`isJavaInternalClass()`, this centralize the types to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
