struberg commented on PR #1328: URL: https://github.com/apache/commons-lang/pull/1328#issuecomment-2542167345
> Note that this PR is worse than I thought because we already have a feature to bypass reflection! Use `EqualsBuilder.setBypassReflectionClasses(List<Class<?>>)`. Are you sure that you really understand that code? If you would setBypassReflectionClasses(ArrayList.class) or HashSet.class or HashMap.class etc, then you would totally break the EqualsBuilder. Because this would also stop looking down into the equality of the elements contained in that List/Set/Map. Funnily you yourself did add hand-tinkered bypasses for those classes in selected places - just not for every use case. So you yourself added code to NOT use reflection for *some* of the cases. So this rather sounds like a strawman argument to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
