struberg commented on PR #1328: URL: https://github.com/apache/commons-lang/pull/1328#issuecomment-2523735365
> I guess you could be bothered to look it up Indeed, had in the back of my mind that Temporal is an abstract class. Latest version uses reflection to figure that a class is not accessible. This works, but maybe we should try a mixture of the old approach + the new one? Thought about having a static `Map<Class, Boolean> KNOWN_INACCESSIBLE_CLASSES` which contains the concrete classes like LocalDate, Boolean, Character, Integer, etc. And then in a second step we do the reflection check. But as this might also have unexpected results (people might forget that they closed the jars) we should probably log it out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
