sebbASF commented on code in PR #308:
URL: https://github.com/apache/commons-validator/pull/308#discussion_r1900442997
##########
src/main/java/org/apache/commons/validator/UrlValidator.java:
##########
@@ -138,7 +138,7 @@ public class UrlValidator implements Serializable {
private static final int PARSE_URL_FRAGMENT = 9;
/**
- * Protocol (ie. http:, ftp:,https:).
+ * Protocol (that is, http:, ftp:, https:).
Review Comment:
I suspect this should be "for example" to allow for other protocol types
##########
src/main/java/org/apache/commons/validator/routines/package-info.java:
##########
@@ -385,7 +385,7 @@
* <li><a href="#other.regex">Regular Expressions</a> - validates
* using Java 1.4+ regular expression support</li>
* <li><a href="#other.checkdigit">Check Digit</a> - validates/calculates
- * check digits (i.e. EAN/UPC, credit card, ISBN).</li>
+ * check digits (that is, EAN/UPC, credit card, ISBN).</li>
Review Comment:
Should be "for example" ?
##########
src/main/java/org/apache/commons/validator/routines/CodeValidator.java:
##########
@@ -59,9 +59,9 @@
* </ul>
* <p>
* Codes often include <em>format</em> characters - such as hyphens - to make
them
- * more easily human readable. These can be removed prior to length and check
digit
- * validation by specifying them as a <em>non-capturing</em> group in the
regular
- * expression (i.e. use the {@code (?: )} notation).
+ * more easily human-readable. These can be removed prior to length and check
digit
+ * validation by specifying them as a <em>non-capturing</em> group in the
regular
+ * expression (for example, use the {@code (?: )} notation).
Review Comment:
I think this should be "that is", not "for example"
##########
src/main/java/org/apache/commons/validator/routines/UrlValidator.java:
##########
@@ -336,7 +336,7 @@ private boolean isOff(final long flag) {
/**
* Tests whether the given flag is on. If the flag is not a power of 2
- * (ie. 3) this tests whether the combination of flags is on.
+ * (that is, 3) this tests whether the combination of flags is on.
Review Comment:
Should be "for example"
##########
src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java:
##########
@@ -473,8 +473,8 @@ public CreditCardValidator(final long options) {
}
/**
- * Tests whether the given flag is on. If the flag is not a power of 2
- * (ie. 3) this tests whether the combination of flags is on.
+ * Tests whether the given flag is on. If the flag is not a power of 2
+ * (that is, 3) this tests whether the combination of flags is on.
Review Comment:
Surely this should be "for example"?
"That is" implies that only 3 is not a power of 2
##########
src/main/java/org/apache/commons/validator/routines/UrlValidator.java:
##########
@@ -325,7 +325,7 @@ protected int countToken(final String token, final String
target) {
/**
* Tests whether the given flag is off. If the flag is not a power of 2
- * (ie. 3) this tests whether the combination of flags is off.
+ * (that is, 3) this tests whether the combination of flags is off.
Review Comment:
Should be "for example"
##########
src/main/java/org/apache/commons/validator/routines/package-info.java:
##########
@@ -369,7 +369,7 @@
* </pre>
* <p>
* <strong>Note</strong>: in theory the other numeric validators besides
- * <em>Float</em>, <em>Double</em> and <em>BigDecimal</em> (i.e. <em>Byte</em>,
+ * <em>Float</em>, <em>Double</em> and <em>BigDecimal</em> (that is,
<em>Byte</em>,
Review Comment:
Does not make sense to me as either "that is" or "for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
