sigee commented on code in PR #308:
URL: https://github.com/apache/commons-validator/pull/308#discussion_r1901652626
##########
src/main/java/org/apache/commons/validator/routines/ISBNValidator.java:
##########
@@ -220,7 +220,7 @@ public boolean isValidISBN13(final String code) {
* Check the code is either a valid ISBN-10 or ISBN-13 code.
* <p>
* If valid, this method returns the ISBN code with
- * formatting characters removed (i.e. space or hyphen).
+ * formatting characters removed (such as space or hyphen).
Review Comment:
Well, formatting characters are called SEP inside the regex pattern.
Based on the SEP constant it could be a hyphen or **any whitespace
character**, not only space.
` private static final String SEP = "(?:\\-|\\s)";`
As I know:
- Space ( )
- Tab (\t)
- Newline (\n)
- Carriage return (\r)
- Form feed (\f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
