garydgregory commented on code in PR #712:
URL: https://github.com/apache/commons-compress/pull/712#discussion_r2378800632
##########
src/main/java/org/apache/commons/compress/archivers/tar/TarUtils.java:
##########
@@ -48,8 +48,7 @@
*
* @Immutable
*/
-// CheckStyle:HideUtilityClassConstructorCheck OFF (bc)
-public class TarUtils {
+public final class TarUtils {
Review Comment:
You cannot make these changes and maintain binary compatibility. Or am I
misunderstanding the JLS and japicmp?
##########
pom.xml:
##########
@@ -300,7 +300,26 @@ Brotli, Zstandard and ar, cpio, jar, tar, zip, dump, 7z,
arj.
<exclude>org.apache.commons.compress.harmony.pack200.SegmentMethodVisitor</exclude>
<exclude>org.apache.commons.compress.harmony.pack200.SegmentAnnotationVisitor</exclude>
<exclude>org.apache.commons.compress.harmony.pack200.SegmentFieldVisitor</exclude>
+ <!-- Compress 1.28.0 -> 1.29.0: make TarUtils final -->
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parseFromPAX01SparseHeaders(java.lang.String)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePAX01SparseHeaders(java.lang.String)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePAX1XSparseHeaders(java.io.InputStream,int)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePaxHeaders(java.io.InputStream,java.util.List,java.util.Map)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePaxHeaders(java.io.InputStream,java.util.List,java.util.Map,long)</exclude>
</excludes>
+ <!--
+ ~ JapiCmp does not support ignoring a specific compatibility
change for a single class.
+ ~ As a workaround, we override the change globally.
+ ~
+ ~ TODO: Remove after release 1.29.0.
+ -->
+ <overrideCompatibilityChangeParameters>
Review Comment:
Obvious -1: We can't break binary compatibility for a trivial style/design
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
