ppkarwasz commented on code in PR #712:
URL: https://github.com/apache/commons-compress/pull/712#discussion_r2379909315
##########
pom.xml:
##########
@@ -300,7 +300,26 @@ Brotli, Zstandard and ar, cpio, jar, tar, zip, dump, 7z,
arj.
<exclude>org.apache.commons.compress.harmony.pack200.SegmentMethodVisitor</exclude>
<exclude>org.apache.commons.compress.harmony.pack200.SegmentAnnotationVisitor</exclude>
<exclude>org.apache.commons.compress.harmony.pack200.SegmentFieldVisitor</exclude>
+ <!-- Compress 1.28.0 -> 1.29.0: make TarUtils final -->
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parseFromPAX01SparseHeaders(java.lang.String)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePAX01SparseHeaders(java.lang.String)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePAX1XSparseHeaders(java.io.InputStream,int)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePaxHeaders(java.io.InputStream,java.util.List,java.util.Map)</exclude>
+
<exclude>org.apache.commons.compress.archivers.tar.TarUtils#parsePaxHeaders(java.io.InputStream,java.util.List,java.util.Map,long)</exclude>
</excludes>
+ <!--
+ ~ JapiCmp does not support ignoring a specific compatibility
change for a single class.
+ ~ As a workaround, we override the change globally.
+ ~
+ ~ TODO: Remove after release 1.29.0.
+ -->
+ <overrideCompatibilityChangeParameters>
Review Comment:
The reason I temporarily disabled `CLASS_NOW_FINAL` instead of excluding
`o.a.c.compress.archivers.tar.TarUtils` from the JapiCmp check is that I
considered it more likely we’d make further adjustments to `TarUtils` before
the release than that we’d mark additional classes as `final`.
That said, I can certainly roll back the `final` modifier on `TarUtils` and
remove this exclusion. The most important part of this PR for me is the change
of many methods from `protected` to package-private (and the removal of
deprecated methods). This way we avoid being locked into keeping obsolete
overloads whenever we need to add an extra parameter, as in #710.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
