ppkarwasz commented on PR #701: URL: https://github.com/apache/commons-compress/pull/701#issuecomment-3341392184
Hi @garydgregory, Yes, I believe #690 is more valuable and should come in first. It gives us a good opportunity to restructure the compressor code into more reusable and maintainable components. Right now much of the compressor logic is still a direct Java translation of defensive C code, which I don’t fully understand myself. That has led to duplication across classes implementing the same algorithms with C-style optimizations that don’t fit well in Java. LHA introduces four additional compression methods, some of which may already overlap with what we have (e.g. in SevenZ). But I don’t currently have the time to review it as thoroughly as it deserves. So my proposal would be: * For **1.29.0**: complete the cycle of archiver improvements we’ve been working on in recent months. * For **1.30.0**: revisit the compression algorithms to identify reusable patterns, reduce duplication, and add LHA support. @fkjellberg: does this plan sound reasonable to you? You have much deeper expertise in compression than we do, so your perspective would be really valuable here. And thank you for your patience. I know your PR has been waiting for review longer than it should, and we’ve been tied up finishing the work from our previous roadmap. I really appreciate the time and effort you’ve already put into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
