fkjellberg commented on PR #701: URL: https://github.com/apache/commons-compress/pull/701#issuecomment-3344006018
Hi @ppkarwasz , The plan to postpone this and my LHA PR until 1.30 sounds good to me. Like you, I also noticed that there are a lot of overlapping code in different compressors that can be refactored for better reuse and to make the code easier to understand. My plan was to create some refactoring PRs once my LHA implementation was merged because I wanted to avoid doing too much refactoring of existing code as part of my PR. The LHA compressor is very similar to the `ExplodingInputStream` in the zip package and I reused the `BinaryTree` and `CircularBuffer` from that package and more refactoring could possibly be done to align both implementations even more. The deflate64 that you started refactoring in this PR is also a good candidate for further refactoring, e.g. the `HuffmanDecoder.DecodingMemory` could possibly be replaced with `CircularBuffer` instead. I think this PR is a good first step in the refactoring process. Let's continue working on refactoring after the 1.29 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
