ppkarwasz commented on PR #422: URL: https://github.com/apache/commons-release-plugin/pull/422#issuecomment-4291717926
Hi @garydgregory, I corrected some minor defects, mostly in documentation, but with two relevant changes: - The attestation didn't have an important `_type` property. :stuck_out_tongue_winking_eye: Fixed in https://github.com/apache/commons-release-plugin/pull/422/commits/476ac4f510f4802d795d65403873b398fa00bed7 - The standard Maven `ScmManager` turned out less useful than I thought: it can not even return the current branch of a Git repo. Since I improved `GitUtils` to test methods against real repositories created by `git`, I just remove `ScmManager` in https://github.com/apache/commons-release-plugin/pull/422/commits/9f69d2e762efba20a24dd3057c7b174aecfb3241 and added some logic to find the current commit SHA1 manually. Since this PR is huge, what do you think about pushing the SLSA models to `master` directly, so we can only discuss the classes that matter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
