ppkarwasz commented on PR #422: URL: https://github.com/apache/commons-release-plugin/pull/422#issuecomment-4381394244
> I added comments. A bunch of new public code with zero tests? Ahem... please fix that. Those classes are DTOs. The surface is getters, setters, and Jackson annotations, and this PR already exercises them indirectly through the code that uses them, so I don't think per-field getter/setter tests would add much. I looked into golden-file tests against canonical examples, but neither in-toto nor SLSA publishes a conformance fixture set, and the parts of the schema that actually vary in practice (`predicate`, `externalParameters`, `internalParameters`) are spec'd as open `object` types. There's a limit to what a round-trip test pins down beyond the field names themselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
