rootvector2 opened a new pull request, #614:
URL: https://github.com/apache/commons-csv/pull/614
With an escape character set and no quote character (or `QuoteMode.NONE`),
`CSVFormat.printWithEscapes` escapes the delimiter, `CR`, `LF`, the escape
character and (since #609) the quote character, but never a comment marker. A
value whose first character is the configured comment marker is written
verbatim, so `CSVPrinter` emits a record that its own `CSVParser` reads back as
a comment and silently drops.
`CSVFormat.DEFAULT.builder().setQuote(null).setEscape('\').setCommentMarker(';').get()`
prints `;foo` for the value `;foo`, and re-parsing that output yields zero
records. Found round-tripping printer output back through the parser.
The escape condition is the right place to fix it, next to where the
delimiter, escape char and quote char are already handled. The change escapes
the comment marker when it is the first character of the value, in both
`printWithEscapes` overloads (`CharSequence` and `Reader`). This is the
escape-mode counterpart to #610, which protected the comment marker only in the
`MINIMAL` quoting path and left the escape paths out.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
