rootvector2 commented on PR #614: URL: https://github.com/apache/commons-csv/pull/614#issuecomment-4753886153
ran `mvn` here and the only failure is `testGetBytePositionMultiCharacterDelimiterWithSupplementaryCharacter`, which fails on `master` too, not from this PR. the `Refactor delimiter in test` commit (a1cf4f2) set the expected value to `"a" + delimiter + "b\n".getBytes(UTF_8).length`. `.length` binds before `+`, so that evaluates to the string `"ax😀2"` rather than the byte count `8`; the prior `"ax😀b\n".getBytes(UTF_8).length` was correct. my change and its two tests are green once that line is restored. want me to drop the one-line fix into this PR, or will you patch master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
