ppkarwasz commented on code in PR #8: URL: https://github.com/apache/commons-xml/pull/8#discussion_r3451183863
########## pom.xml: ########## @@ -104,7 +104,7 @@ limitations under the License. </dependencies> <build> - <defaultGoal>clean checkstyle:check spotbugs:check verify</defaultGoal> + <defaultGoal>clean checkstyle:check spotbugs:check pmd:check verify</defaultGoal> Review Comment: **Question**: why do Commons projects add check executions to the default goal, instead of binding them to the `verify` phase? I find it always very confusing, when a `mvn verify` succeeds, but the CI fails. The behavior is also inconsistent: Javadoc compilation with `-Xdoclint` is part of the standard lifecycle (and often fails due to various bugs and breaking changes between JDK 8 and JDK 25), while other checks are not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
