garydgregory commented on code in PR #8: URL: https://github.com/apache/commons-xml/pull/8#discussion_r3451353505
########## pom.xml: ########## @@ -104,7 +104,7 @@ limitations under the License. </dependencies> <build> - <defaultGoal>clean checkstyle:check spotbugs:check verify</defaultGoal> + <defaultGoal>clean checkstyle:check spotbugs:check pmd:check verify</defaultGoal> Review Comment: I find it harder to customize what I want to do on the command line if the POM does more magic (and is larger) and I can't do simple atomic actions on the CLI. The default goal seems seems like the best place to say: this is all that should happen by default, if you want something else, do it with more arguments. Reading through a whole POM instead of looking at the ONE default goal line is simpler IMO. All Commons components are setup up this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
