rootvector2 commented on PR #695: URL: https://github.com/apache/commons-collections/pull/695#issuecomment-4806549677
Fair point, the per-index guard only stops the single out-of-range value from being stored, it doesn't make `merge` atomic. Any valid indices ahead of the bad one are already in the `TreeSet` when it throws, so the filter can still hold bits that map to no real hash. It narrows the common single-bad-index case but isn't a full fix. Pulling `isValid()` up to `BloomFilter` as a default returning `true`, then implementing it per filter, sounds like the right direction. Happy to defer to @aherbert if he picks up that PR, or I can add the Javadoc note here in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
