rootvector2 commented on PR #695: URL: https://github.com/apache/commons-collections/pull/695#issuecomment-4811417735
Makes sense, agreed a guard can't make the merge atomic. Reverted the code change and documented the contract instead: added a note on the `BloomFilter` interface that merge enables indexes one at a time and isn't atomic, so an exception leaves the filter holding earlier indexes and it should be treated as invalid. Dropped the `SparseBloomFilter` change and its test, so the PR is now just the Javadoc plus a changes.xml line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
