rootvector2 opened a new pull request, #630: URL: https://github.com/apache/commons-csv/pull/630
`createHeaders()` runs inside the `CSVParser` constructor, after the lexer already owns the reader returned by `builder.getReader()`, so a duplicate or missing header name throws before the caller receives a `Closeable` and nothing is left to close the input with. For `parse(Path)`, `parse(File)`, `parse(URL)` and the `Path`/`File`/`URI` builder forms the library opened that stream itself, so the descriptor or connection stays open for the lifetime of the JVM. Found while checking what happens to the handle when a header fails validation. The constructor is the layer that took ownership and every entry point funnels its reader through it, so closing there covers all of them; a close failure is attached as suppressed so the original error still surfaces. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
