garydgregory commented on PR #630: URL: https://github.com/apache/commons-csv/pull/630#issuecomment-5151231875
Hello @rootvector2 This one feels wrong to me. In git master, please find the new `CSVParserTest.testTryWithResourcesParse*` - `testTryWithResourcesParseInputStreamWhenHeaderIsInvalid` - `testTryWithResourcesParseReaderWhenHeaderIsInvalid` It is the responsibility of the code that allocates a resource to close it. If the the resource is managed with a try-with-resources block (see the new tests), the resource is closed for this use case. I switched the PR to draft for this reason. Please let me know how you see it. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
