Copilot commented on code in PR #649:
URL:
https://github.com/apache/commons-configuration/pull/649#discussion_r4083922101
##########
pom.xml:
##########
@@ -48,6 +48,7 @@
org.apache.commons.codec.*;resolution:=optional,
org.apache.commons.jxpath.*;resolution:=optional,
org.apache.xml.resolver.*;resolution:=optional,
+ java.applet.*;resolution:=optional,
Review Comment:
`Import-Package` patterns that use `java.applet.*` may not match the base
package `java.applet` (wildcards typically match subpackages, not the package
itself). If `AppletConfiguration` directly references `java.applet.Applet`,
missing an explicit `java.applet;resolution:=optional` import can still break
resolution on runtimes where it exists. Consider importing `java.applet`
explicitly (and only keep `java.applet.*` if you truly need subpackages).
##########
pom.xml:
##########
@@ -541,6 +542,35 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>java26</id>
+ <activation>
+ <jdk>[26,)</jdk>
+ </activation>
Review Comment:
The new `java26` profile is non-obvious without context. Add a short XML
comment explaining why JDK 26+ requires excluding `TestAppletConfiguration`
(Applet API removed) and why `TestWebdavConfigurationBuilder` is also excluded
here, so future maintainers understand the rationale and intended scope.
##########
pom.xml:
##########
@@ -541,6 +542,35 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>java26</id>
+ <activation>
+ <jdk>[26,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <testExcludes>
+ <testExclude>**/TestAppletConfiguration.java</testExclude>
+ </testExcludes>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/TestWebdavConfigurationBuilder.java</exclude>
+ <exclude>**/TestAppletConfiguration.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
Review Comment:
The PR description says the only change is adding an optional
`java.applet.*` import, but this diff also introduces a new `java26` profile
that changes test compilation/execution behavior. Please update the PR
description (or split the change) so reviewers and release notes accurately
capture that JDK 26+ will skip these tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
